Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to remember last opened Extensions in Dynamo #13812

Merged
merged 65 commits into from
Mar 14, 2023

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Mar 10, 2023

Purpose

https://jira.autodesk.com/browse/DYN-5570
This PR adds an option to remember last opened Extensions, a new toggle button is added under Features > Extensions section of preference panel to enable/disable this feature.
When enabled, the user will see view extensions which were open while closing Dynamo in the last session.
When disabled, dynamo will not open extensions from the prior session or save their state.
The extensions are serialized in the settings XML file.

Unit tests added -

  • When option is enabled, checks if extensions that were open while closing Dynamo during the last session do reopen.
  • When option is enabled, checks if extensions that were closed while closing Dynamo during the last session do not reopen.
  • When option is disabled, checks if extensions that were open while closing Dynamo during the last session do not reopen.

Snapshot:
DynamoSandbox_UeDuVULa4i

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • Add an option to remember last opened Extensions in Dynamo

Reviewers

@DynamoDS/dynamo

@@ -771,7 +771,7 @@ public string SelectedPythonEngine
}

/// <summary>
/// Controls the IsChecked property in the "Hide IronPython alerts" toogle button
/// Controls the IsChecked property in the "Hide IronPython alerts" toggle button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@@ -63,6 +63,7 @@ namespace Dynamo.Controls
public partial class DynamoView : Window, IDisposable
{
public const string BackgroundPreviewName = "BackgroundPreview";
private const int SideBarCollapseThreshold = 20;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually a nice thing to add to the preferences!

@mjkkirschner
Copy link
Member

mjkkirschner commented Mar 10, 2023

looks pretty solid @zeusongit - a few comments.

@mjkkirschner
Copy link
Member

some test failures on latest commits.

@QilongTang QilongTang added this to the 2.18.0 milestone Mar 13, 2023
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with couple comments

@QilongTang
Copy link
Contributor

Thanks @zeusongit Since I see the previous Dynamo SelfServe check already passed, will merge once basic ones passing

@zeusongit zeusongit merged commit 58a4593 into DynamoDS:master Mar 14, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
…13812)

Add an option to remember last opened Extensions in Dynamo
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
Add an option to remember last opened Extensions in Dynamo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants