Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4308 Input and output port menu Y location #13683

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jan 17, 2023

Purpose

The PR solves an outstanding issue DYN-4308 'Input and output port menu is tiny when zoomed in and gets bigger when zoomed out'. The way the Y value of the popup context menu position was calculated did not take into account a few factors, which reflected in inaccurate position in different scale factors in relationship to the corresponding port.

Location after the solution

popup_solution

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User-facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • Complete rework of how the vertical position of the Popup was calculated
  • Now takes into account all relevant variables, including node header height, port height, port position, tooltip height
  • Takes into account scalable vs non-scalable

Reviewers

@reddyashish

FYIs

@Amoursol
@Jingyi-Wen

…igger when zoomed out

- redo of the Y position calculation
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@reddyashish reddyashish marked this pull request as ready for review January 19, 2023 15:12
@reddyashish
Copy link
Contributor

The failing test here WorkspaceContextMenu_TestIfSearchTextClearsOnOpeningContextMenu is flaky.

Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reddyashish reddyashish merged commit 983da29 into DynamoDS:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants