Live Chart Dynamo Implementation #13631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added Live Charts to Dynamo UI Nodes - this is the first commit for this PR
|
Hi Team, Live Charts is old at the moment, can be consider use Live Charts 2 ? |
pinzart90
reviewed
Dec 13, 2022
- created a resource dictionary for custom default charts theme
- added supporting files for Dynamo Dictionary (icons, dyn example files, image example files, markdown (markdowns are 'empty', to be detailed by UX team) - changed namespace for Live Chart nodes
Hi Chuong! LiveCharts2 is indeed way more expansive, but due to the dependencies involved we are opting for the original for now as we aim to keep Dynamo's dependency landscape as small as possible. @mjkkirschner can probably elaborate more 😊 |
- renamed help files to match node full (type) names
- testing AstFarctory.BuildFunctionCall when method is in another assembly - added Helper class to provide Colors from the LiveCharts xaml dictionary - rework of BarChartNodeModel to allow for a non-nested value/input
- moved helper functions to the DynamoCore assembly to satisfy AstFactory conditions - BarChart now works with both List<double> and List<List<double>>
- added LiveCharts to Dynamo license files
- updated all the rest of the functions (besides the BarChart) - all charts now work with/without Color input - fixed old/wrong example dyn files
- multiple small visual updates
- added 26 default colors to cycle through, if the user is not providing custom colors
- changed visual style of the resizing thumb for the chart controls - added tooltip - tooltip text added to resources
…iveChartImplementation"" This reverts commit cc95adf.
…iveChartImplementation"" This reverts commit ce8acae.
- added the nodes to the library - added icons to nodes - added Alert message when default Colors are provided
- as discussed, undid the <UseWPF>true</UseWPF> setting
- swapped localization strings with resources
- the icon used for resizing the node UI window now consistent with other UI nodes, such as Watch, Watch3D
- added basic creation tests for LiveCharts - threading issues does not allow output to be tested
- changed the notification text when user provides no colors or mismatching color structure
sm6srw
requested changes
Jan 24, 2023
src/Libraries/CoreNodeModelsWpf/Charts/Controls/BarChartControl.xaml.cs
Outdated
Show resolved
Hide resolved
- added dispose methods to LiveChart View and ViewModel classes - reverted small change previously made with no relevance to this PR
sm6srw
requested changes
Jan 26, 2023
src/Libraries/CoreNodeModelsWpf/CoreNodeModelsWpf - Backup.csproj
Outdated
Show resolved
Hide resolved
src/Libraries/CoreNodes/ChartHelpers/BasicLineChartFunctions.cs
Outdated
Show resolved
Hide resolved
- removed old backup file - changed Dispose (not being triggered) to Unload to dispose of eventhandlers - cleaned up old TODO remarks
sm6srw
reviewed
Jan 30, 2023
sm6srw
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Tests passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8285/
This is now ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a Dynamo Implementation of the NodeModelCharts from Keith Alfaro implements Graphing Utility Nodes.
The goal of this PR is to empower Dynamo users to better understand, work with, and visualize their data through interactive and responsive graphical charts that work both within the Dynamo workspace and allow propagation up through Dynamo Player.
before
after
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@mjkkirschner
FYIs
@Amoursol