localize obsolete messages in protogeo #13580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
commented
Nov 29, 2022
| { | ||
| if (resourceType == null) |
There was a problem hiding this comment.
this is moved to base class
mjkkirschner
commented
Nov 29, 2022
| Message = message; | ||
| } | ||
| } | ||
| [AttributeUsage(AttributeTargets.Method| AttributeTargets.Constructor | AttributeTargets.Property)] |
There was a problem hiding this comment.
can now be applied to more function types.
mjkkirschner
commented
Nov 29, 2022
| /// <param name="descriptionResourceID">resx id for this resource</param> | ||
| /// <param name="typeName">name of type that contains resource strings.</param> | ||
| /// <exception cref="ArgumentNullException"></exception> | ||
| public IsObsoleteAttribute(string descriptionResourceID, string typeName) |
There was a problem hiding this comment.
this is very useful for autogen because we can't reference the type inside the resource assembly in some situations - but we know the type name and assembly name.
mjkkirschner
changed the title
|
test failure is the flaky one - I will file task to fix that. |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Dec 5, 2022
* move resx lookup to base class so libG can use it * add new constructor for when we only know type name, but cant reference actual type * can apply to different function types * comments
aparajit-pratap
pushed a commit
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-5249
This PR adds localization capabilities into the base class of our custom obsolete attribute types. This way it can be used from LibG.
This PR must be merged and ideally generate a nuget package before we can merge the related LibG PR which localizes most obsolete node messages.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Improves API for localizing obsolete node messages
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of