Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Help Images and Dynamo Files Update #13568

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 24, 2022

Purpose

The goal of this PR is to update the image files used to provide helpful information via the Documentation Browser to the latest design guidelines of Dynamo as of the current patch 2.17. The PR also introduces the Dynamo example files associated with most of the Node help files.

Generating the images was automated using the ExportSampleImagesViewExtension and from the dynamo files also included with this PR. The Example dynamo files were taken from the EXAMPLE folder of the Dynamo Dictionary repository located here. The images were matched to the markdown files inside the NodeHelpFiles. A number (60) of new Example files were manually created and added to this PR. There is still a discrepancy in the number of help markdown files and dynamo example files.

PR comparison

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • updated Images to Node Help files to reflect the current state of Dynamo design (patch 2.17)
  • added Dynamo Example graph files (.dyn)

Reviewers

@reddyashish

FYIs

@QilongTang

- updated Images to Node Help files to current reflect current state of Dynamo design (patch 2.17)
- added Dynamo Example graph files (.dyn)
@QilongTang QilongTang added this to the 2.17.0 milestone Nov 24, 2022
@reddyashish reddyashish merged commit 7c44c7c into DynamoDS:RC2.17.0_master Nov 28, 2022
reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request Nov 28, 2022
- updated Images to Node Help files to current reflect current state of Dynamo design (patch 2.17)
- added Dynamo Example graph files (.dyn)

(cherry picked from commit 7c44c7c)
reddyashish added a commit that referenced this pull request Nov 28, 2022
- updated Images to Node Help files to current reflect current state of Dynamo design (patch 2.17)
- added Dynamo Example graph files (.dyn)

(cherry picked from commit 7c44c7c)

Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants