Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slider localization bug #13348

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Sep 27, 2022

Purpose

https://jira.autodesk.com/browse/DYN-5291
Fixes slider localization bug and adds a test.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Fix slider going out of control while sliding in localized environments.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner mjkkirschner merged commit 9dcde41 into DynamoDS:master Sep 27, 2022
@mjkkirschner mjkkirschner deleted the dyn5291 branch September 27, 2022 17:41
@QilongTang QilongTang added this to the 2.17.0 milestone Sep 28, 2022
QilongTang pushed a commit that referenced this pull request Jun 28, 2023
* fix slider localization bug
add test

* comment

Co-authored-by: kirschm <[email protected]>
@QilongTang QilongTang mentioned this pull request Jun 28, 2023
9 tasks
QilongTang added a commit that referenced this pull request Jul 6, 2023
* version changes

* fix slider localization bug (#13348)

* fix slider localization bug
add test

* comment

Co-authored-by: kirschm <[email protected]>

* update

---------

Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants