Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "setting exit tour method to internal and calling it when a new workspace is set" (#13180) #13204

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Aug 11, 2022

Purpose

After some testing, I found that the self-serve tests on master-15 are failing due to this change:
#13180

Comparison:
Master(head pointing to: #13178): https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1066/ has -500 failing tests.

Master(with reverting #13180) https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1065/ passing all tests.

I am not exactly sure why all the json serialization tests are failing in this case. I think, there is one test failing which is causing all those failures but I cannot pin-point it yet. Looking more into it.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Reviewers

@filipeotero @QilongTang @mjkkirschner

@reddyashish
Copy link
Contributor Author

reddyashish commented Aug 11, 2022

@reddyashish
Copy link
Contributor Author

reddyashish commented Aug 11, 2022

I think that the tests were failing because ExitGuidedTourIfOpened is called everytime a workspace a changed. To avoid that, changed the condition to call that method only in non-test mode. All the tests now pass on master-15: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1068/

@QilongTang QilongTang merged commit db66e15 into DynamoDS:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants