Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize watch node when I have a lot of data as single item in a collection. #13169

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Aug 3, 2022

Purpose

Task: https://jira.autodesk.com/browse/DYN-5100

The resize thumb should be shown if the input is a single dictionary with multiple items. Added a condition to show the resize icon when the max depth of the collection + number of items is greater than 5.

Screen Shot 2022-08-03 at 12 26 43 PM

Screen Shot 2022-08-03 at 12 27 02 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Resize watch node when I have a lot of data as single item in a collection.

Reviewers

@QilongTang @zeusongit @jesusalvino

@QilongTang
Copy link
Contributor

@jesusalvino can you give this a review?

@QilongTang QilongTang merged commit 9f4f8fa into DynamoDS:master Aug 5, 2022
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants