Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note PinUnpin Bugfix #12925

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 25, 2022

Purpose

This is a minor Bug fix. The ability to Redo after a Note has been Pinned to a Node and Undo is triggered.

Task: https://jira.autodesk.com/browse/DYN-4828

redo-pin-note

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • NodeModel.cs - new Action that is triggered on Undo/Redo
  • NoteViewModel.cs - new logic that handles both Pin/Unpin scenarios when performing Undo/Redo

Reviewers

@reddyashish

FYIs

@mjkkirschner
@Amoursol

@dnenov dnenov marked this pull request as draft May 25, 2022 15:23
@dnenov dnenov mentioned this pull request May 25, 2022
8 tasks
- fixed an issue where a previously selected Node will get the target for re-pinning after Undo
- small clean-up from existing code
- attempt to fix multiple unit tests failing
@reddyashish
Copy link
Contributor

All tests passed on master-15. Opening this PR

1 similar comment
@reddyashish
Copy link
Contributor

All tests passed on master-15. Opening this PR

@reddyashish reddyashish marked this pull request as ready for review May 27, 2022 17:04
@reddyashish
Copy link
Contributor

@QilongTang @zeusongit Merging this. Let me know if you have any concerns.

@reddyashish reddyashish merged commit 52004fa into DynamoDS:master Jun 1, 2022
@QilongTang QilongTang added this to the 2.15.0 milestone Jun 1, 2022
@QilongTang
Copy link
Contributor

@reddyashish Can you assign the related Jira task to test? Is it DYN-4828?

@reddyashish
Copy link
Contributor

Yes. Will update the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants