Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4794 Run status msg update based on warnings dismiss states #12882

Merged
merged 5 commits into from
May 23, 2022

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented May 13, 2022

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per https://jira.autodesk.com/browse/DYN-4794,

  1. Update descriptions in current "Dismiss" feature to showcase that it's a temporary state and not saved into the graph.
  2. Update the run message to state "Run completed with dismissed warnings." or simply "Run completed" rather than "Run completed with warnings" as is today.

Example:
WorkspaceRunStatusMsg

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Run status msg update based on warnings dismiss states

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang modified the milestone: 2.15.0 May 13, 2022
@QilongTang
Copy link
Contributor Author

It is still unclear to me if we do want to bring in this change to Dynamo in 2.15.0. If you have any opinions or can think of more edge cases, please let me know.

@QilongTang QilongTang marked this pull request as ready for review May 19, 2022 19:15
@QilongTang QilongTang added this to the 2.15.0 milestone May 19, 2022
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang
Copy link
Contributor Author

Checked there is no real regression. Merging

@QilongTang QilongTang merged commit 64cd96e into master May 23, 2022
@QilongTang QilongTang deleted the RunStatusMsgIMP branch May 23, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants