Dyn 4715 package name special characters

[jesusalvino]

Purpose

Prevent user from enter some special characters as part of the package name in the Publish Package feature.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated

###Reviewers
@QilongTang

###FYIs
@RobertGlobant20 @filipeotero

[jesusalvino]

[QilongTang]

What are the changes to this style?

[jesusalvino]

What are the changes to this style?

adds an extra space to the right side of the input to draw the Icon that will be displayed if required

[QilongTang]

Regression also to look at

[Test Result] (1 failure / +1)
[Dynamo.Tests.Search.SearchDictionaryTest.TestContainsSpecialCharacters]

[QilongTang]

One comment then LGTM

[zeusongit]

So just to be clear this will not affect the packages which already have spaces and want to publish a new version, but will prohibit future package names to include spaces, right? @QilongTang @jesusalvino
I think we should also make a special note of it in the next release.

[mjkkirschner]

So just to be clear this will not affect the packages which already have spaces and want to publish a new version, but will prohibit future package names to include spaces, right? @QilongTang @jesusalvino I think we should also make a special note of it in the next release.

What about users publishing new versions of existing packages with spaces? Won't this stop them from updating existing packages? - same question as @zeusongit 👍

[QilongTang]

FYI.. @zeusongit @mjkkirschner see this comment, space is excluded from .NET API so not considered special char in Dynamo

[zeusongit]

Thanks for the clarification @QilongTang 👍🏼

[QilongTang]

So just to be clear this will not affect the packages which already have spaces and want to publish a new version, but will prohibit future package names to include spaces, right? @QilongTang @jesusalvino I think we should also make a special note of it in the next release.

What about users publishing new versions of existing packages with spaces? Won't this stop them from updating existing packages? - same question as @zeusongit 👍

See my comment in code

[QilongTang]

@jesusalvino Looks like there are still regressions to deal with before we can merge

[QilongTang]

Looking at this PR again, I still would not prefer this way. The original getter of invalid chars lives inside of search dictionary which seems strange. Can you move this static getter to https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoUtilities/PathHelper.cs and have ContainsSpecialCharacters refer to this property? And instead of the getter pointing to a function elsewhere, I would just return System.IO.Path.GetInvalidFileNameChars().Where(x => !char.IsWhiteSpace(x) && (int)x > 31).ToArray();

[QilongTang]

More changes requested @jesusalvino