-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGD-2199 - custom dropdown node #11958
Merged
Changes from 3 commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
2fdcfcc
First successful build
LongNguyenP 30e278d
Added to Library View Extension
LongNguyenP c0553ff
Remove dependency on PresentationCore.dll
LongNguyenP 00587d3
Updated some attributes
LongNguyenP 37f164b
Added some resource strings
LongNguyenP 795dfd7
AssemblySharedInfo
LongNguyenP d15bfd1
Changed name to "Custom Dropdown"
LongNguyenP 975b821
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into AGD-…
LongNguyenP 047b9e2
Added MD file
LongNguyenP 4c843b2
Made changes to address two failed tests
LongNguyenP c05095f
Fix broken tests (#12082)
saintentropy 8b1d743
Added test related files
LongNguyenP 93377f7
AGD 2199 Test Fix (#12161)
saintentropy b1ec208
Merge branch 'master' into AGD-2199
saintentropy 0960dd5
Merge branch 'master' of https://github.com/DynamoDS/Dynamo into AGD-…
LongNguyenP 9361301
Modern styling applied to CustomDropdown node
LongNguyenP a37cb5e
Update MarkdownGeneratorCommandTests.cs
saintentropy 93f4013
Merge branch 'master' into AGD-2199
LongNguyenP d6e00e2
Resolved PR conflicts with master
LongNguyenP d576591
Midway commit
LongNguyenP b6cc773
Cleanup mostly done
LongNguyenP 00c78e1
Addressed all issues related to first PR review round
LongNguyenP 103b0ea
Removed .idea directory and added it to .gitignore
LongNguyenP 312bd9e
Icon
LongNguyenP 0fb12c6
Merge branch 'master' into AGD-2199
LongNguyenP 9e25ff2
Merged from master
LongNguyenP 83f201f
Waypoint
LongNguyenP 58d37ee
Error
LongNguyenP 4e0473a
Commit just before fixing bug related to JSON deseiralization
LongNguyenP 34a82ba
Fixed regression bug
LongNguyenP 5a4ac2c
DYN file test completed
LongNguyenP 6d17a1a
Merge branch 'master' into AGD-2199
LongNguyenP 8999190
Added tests and simplify some methods
LongNguyenP 1423185
Addded the .dyn file required for tests to git tracking
LongNguyenP b4bc256
Corrected node name
LongNguyenP 68b99df
Addressed a couple of PR comments
LongNguyenP 07c08c7
Deleted unused method
LongNguyenP 0a425ef
Merge branch 'master' into AGD-2199
LongNguyenP 4794e0f
Solved conflict with master
LongNguyenP bc67923
A couple of changes
LongNguyenP a1d597c
AssemblySharedInfo
LongNguyenP 51e71ae
Merge branch 'master' into AGD-2199
LongNguyenP c8cb45a
Undid whitespace removal
LongNguyenP 58c17ba
Undid blank line at the end of file
LongNguyenP 35effd3
Undid whitespace removal
LongNguyenP beccd48
Undid whitespace removal
LongNguyenP dad3c80
Undid whitespace removal
LongNguyenP 99bec28
Undid blank line
LongNguyenP 2bf0479
Revert XML indent size to 2 whitespaces
LongNguyenP 49bfb1b
Revert "Undid blank line"
LongNguyenP 9cf40e5
Revert blank line
LongNguyenP 5a60114
Undid auto whitespace removal
LongNguyenP 1f14c3e
Undid auto whitespace removal
LongNguyenP 5ac8d1b
Undid auto whitespace removal
LongNguyenP 8129161
Undid auto whitespace removal
LongNguyenP 9576110
Revert version number
LongNguyenP e4e1345
Undid auto whitespace removal
LongNguyenP 6c465dc
Deleted two auto-generated resource cs files
LongNguyenP 9c80434
Fix build
saintentropy 9bb71ce
Merge remote-tracking branch 'origin/master' into AGD-2199
twastvedt e849045
Don't hold separate source of truth, use Dynamo UI components.
twastvedt c41f397
Fix formatting.
twastvedt f036043
Remove INotifyPropertyChanged from DynamoDropDownItem.
twastvedt b445a0a
Fix some binding updates.
twastvedt bea4f47
Improve tab navigation.
twastvedt b322185
Fix more binding updates.
twastvedt 490905e
Remove logging.
twastvedt 882e237
Fix remove button styling.
twastvedt 4ec277d
Rename to match current convention.
twastvedt d916b86
Fix build by removing last line of AssemblySharedInfo.tt?
twastvedt 8b53b5c
Merge branch 'master' into AGD-2199
twastvedt a1a783f
Clean up tests.
twastvedt 6214991
Clean up unnecessary changes.
twastvedt b591474
Clean up extra styling.
twastvedt 5327934
Match +/- button color with existing nodes.
twastvedt f64efbf
Add serialization.
twastvedt d952576
Undo unnecessary changes.
twastvedt 8839d44
Fix image class names.
twastvedt 920e548
Fix copy/paste deserialization.
twastvedt 443d557
Actually fix icon images.
twastvedt ef941ea
Fix dropdown test.
twastvedt 22199a4
Remove lacing comment.
twastvedt 1b7fe1a
Merge branch 'master' into AGD-2199
twastvedt e776bd4
Merge branch 'master' into AGD-2199
twastvedt 88b4f6c
Add custom selection documentation files.
twastvedt 5e1eef9
Update incorrect documentation on DoubleInput.
twastvedt 0b11cd6
Merge branch 'AGD-2199' of https://github.com/DynamoDS/Dynamo into AG…
twastvedt 27ccb15
Treat null AST as primitive for update graph execution cycle (#13221)
aparajit-pratap 752c90f
Fix some tests.
twastvedt 882f0b5
Merge branch 'AGD-2199' of https://github.com/DynamoDS/Dynamo into AG…
twastvedt 223deee
Merge branch 'master' into AGD-2199
twastvedt f0b7445
Revert template change.
twastvedt 86c439d
Fix comment text.
twastvedt 7f74e9e
Localize output description.
twastvedt 1ba123d
Add documentation.
twastvedt ae35692
Reduce property visibility.
twastvedt 7a5992b
Fix inline if format.
twastvedt 735d0c4
Docs.
twastvedt 80ad1d1
Reduce whitespace.
twastvedt 24e8014
Docs fix.
twastvedt 45047e7
Naming fixes.
twastvedt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
doc/distrib/NodeHelpFiles/CoreNodeModels.Input.CustomSelection.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ## In Depth | ||
| The Custom Dropdown node allows a user to create a dropdown selection input with custom labels and values. If all values are numbers, the output will be a double, and if all values are integers the output will be an integer. In the example below, "Two" is selected in the Custom Dropdown Menu node, making the output of that node the integer `2`. | ||
| ___ | ||
| ## Example File | ||
|
|
||
|  | ||
Binary file added
BIN
+32.4 KB
doc/distrib/NodeHelpFiles/CoreNodeModels.Input.CustomSelection_img.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if the types are mixed? Can you use strings? What are valid value types etc?
Is this dynamic behavior important - I ask this because as we're working on the MSIL compiler - it's very hard to determine the output types of nodes that have dynamic behavior like this - not super important but I imagine that if we move forward with that work outside of a POC we're going to need some principles around not introducing dynamic behavior without a really good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Immediate answers: values default to strings unless the criteria are met. So, anything's valid, it will just be a string unless we can make everything numbers. I'll add that, or whatever we decide here, to the description.
I'm definitely open to alternatives, though I think this behavior is pretty convenient, intuiting a user's expectations in most common scenarios. I'm not sure what the alternative to dynamic behavior here is. Separate String custom selection and Number custom selection nodes sounds awkward for the user. I imagine the original inspiration for this part may have been the experience in Grasshopper. Though there it's less a feature of the custom selection node itself and more of the global type coercion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's put this on the back burner.