-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove nodehelp control #11660
remove nodehelp control #11660
Conversation
@Astul-Betizagasti noted that currently they are obsoleting the old controls, so I think it's fine to do the same here for now until we discuss API surface rules. |
@mjkkirschner, related about what you were saying about WPF Controls (not sure if you are just talking about Properties in the ViewModel or controls in the XAML file), some days ago I created a new pull request for enabling the Geometry Scaling and Render Precision features in the Preferences panel, so I deleted the old code related to the Geometry Scaling functionality (xaml, code behind, events, commands, methods .....), is that ok? or should I marked as Obsolete? Thanks |
@RobertGlobant20 - I'm not sure - I think the safest thing to do for now is to obsolete anything public, add a TODO and we should discuss with @QilongTang how to approach it. If we are going to start treating public methods and classes in for this PR - that was what I was going to do -
|
Hey @mjkkirschner What we used to do was that: Currently, we are treating DynamoView out of API scope, which means we can move/delete XML wpf controls as we want. For any public properties exposed under If you have any preference, feel free to update here or on slack conversation: https://autodesk.slack.com/archives/C01C2AGPSG2/p1620055650102300 |
@QilongTang okay - will proceed same as Morpheus team, filed a task for the messaging. |
This comment was marked as spam.
This comment was marked as spam.
keep test for dictionary
Purpose
When markdown docs for nodes were added to the docs browser - the old
NodeHelpPrompt
control was no longer displayed. It's not used anywhere in Dynamo today and likely will not be.This PR just obsoletes it, so we get rid of it later at a major release.This PR removes the control, but leaves the test as it doesn't really have anything to do with the control - it tests a function on NodeModel and still passes.
Declarations
Check these if you believe they are true
*.resx
files