Dyn 3513 preferences modal dialog #11534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a new workflow (issue_type_predicte.yaml) that is using the ML.NET model for predicting the issue type (source repo), so If a new issue is created in the Dynamo repo this workflow will run and will predict if is a Wishlist issue or not. If is a Wishlist issue it will be labeled as "Wishlist" and then another workflow will move the issue to the DynamoWishlist repo. If the issue is incomplete or is not valid the label "NotMLEvaluated" will be added to the issue. Also I added two scripts more, one will return the issue body in a json string and the other one will clan the issue body removing sections not used like "Dynamo Version" or "Stack Trace"
When testing the issue predicter workflow the issues labeled as Wishlist were not moved to the DynamoWishlist repo due that the "Move Issue by labels" workflow failed. There was a problem with the PAT used to label the issue, I was using the wrong one (no triggers actions).
I added a new View(xaml) for the Preferences window also I added several entries in the Resources so they can be used in the PreferencesView.xaml. This changes only will satisfy the next requirements: - The modal dialog should come with Preferences Title - The modal dialog should come with Save Changes button - The modal dialog should come with split lines - Dynamo will be blocked until user exit that dialog
Updated the TabControl and TabItem because the Background property was set incorrectly in some places.
When merging the master branch (after updating my forked repo), i got several conflics in the Resources file, then I had to re-add the resources. In the DynamoView I added the necessary code to launch the Preferences window when the user click the option in the Dynamo menu. Finally I did some minor changes in the Preferences view.
In the title bar the drag & drop was not working correctly so I increased the width of the TextBlock.
Removing changes in Assembly file
|
Here is a gif of the new Preferences window. |
QilongTang
reviewed
Mar 5, 2021
QilongTang
reviewed
Mar 5, 2021
Based on the code review comments: I moved the styles to the DynamoModern.xml I added several comments in the PreferencesView.xaml
QilongTang
reviewed
Mar 8, 2021
I removed one line in the csproj file because is not needed.
QilongTang
approved these changes
Mar 8, 2021
|
@QilongTang question about the funky commits here, were these not squashed by accident or are all these commits showing up anyway for some reason? |
This is usually because of how developer leverage local fork, we can check with @RobertGlobant20 . I bet instead of pulling upstream, some client do merge commits so the fork head looks really messy with bunch of commits with same title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create a new modal dialog for the new Preferences window.
The requirements are the next ones:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Astul-Betizagasti @alfredo-pozo