-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AGD-1882] Support storing user defined graph documentation #11444
Merged
mjkkirschner
merged 7 commits into
DynamoDS:master
from
SHKnudsen:AGD-1882-support-storing-user-defined-Graph-documentation
Mar 18, 2021
+119
−8
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2c024bd
workspacemodel thumbnail api + test
SHKnudsen 3411807
Merge remote-tracking branch 'upstream/master' into AGD-1882-support-…
SHKnudsen 8f2194e
add graphDocumentationURL + serialise and deserialise Author
SHKnudsen 73049ca
Update WorkspaceModel.cs
SHKnudsen ed38bd0
handle empty URIs
SHKnudsen 5cc17c4
Update 2080_JSONTESTCRASH undo_redo.dyn
SHKnudsen 6807f8f
move thumbnail and help link to HomeWorkspaceMode
SHKnudsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before this gets merged- a quick thought, do all of these new properties make sense on both home workspaces and custom node workspaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh I hadn't considered that this also affected the CN workspace. Most of these probably don't make sense on the CN, maybe the
Author
is okay, but not sure i see the need for the others.@nate-peters @saintentropy, any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just noticed that its the same with the new
ExtensionWorkspaceData
not sure that makes sense in the CN workspace either?