Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python.runtime to include changes to support IDisposable types in Python context manager #11433

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jan 27, 2021

Purpose

Update python.runtime.dll for changes to support IDisposable types in Python context manager: https://git.autodesk.com/Dynamo/pythonnet/pull/21

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

@mjkkirschner
Copy link
Member

mjkkirschner commented Jan 28, 2021

@aparajit-pratap something to consider - is the version number of this binary the same as before or has the revision number incremented? If it's exactly the same it may not be updated correctly by patch installers...

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Jan 28, 2021

@mjkkirschner the version number is the same. How do I increment the version number for the binary? @mmisol?

@aparajit-pratap aparajit-pratap merged commit 2c4e7ef into DynamoDS:master Jan 28, 2021
@aparajit-pratap aparajit-pratap deleted the updatePython branch January 28, 2021 21:27
aparajit-pratap added a commit to aparajit-pratap/Dynamo that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants