Fix for regression in Node2Code. #11373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aparajit-pratap thanks for fixing this so quickly, |
| @@ -106,7 +106,7 @@ public override AssociativeNode VisitIdentifierNode(IdentifierNode node) | |||
| // return IdentifierNode if identifier string is not separated by '.' | |||
| if (strIdentList.Length == 1) | |||
| { | |||
| return new IdentifierNode(strIdentList[0]); | |||
| return node; | |||
There was a problem hiding this comment.
If my memory serves correctly, then the AST walkers are a bit inconsistent when it comes to returning new AST nodes or the same node - maybe this should return a copy of the node instead?
There was a problem hiding this comment.
The AST walkers are meant to return new nodes only if they are rewritten and return the original node if there is no change.
There was a problem hiding this comment.
ah! Is that documented somewhere? Would it make sense to add a note about that to the base class or something? Not that it needs to be part of this pr.
aparajit-pratap
changed the title
mmisol
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix for regression in Node2Code.
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@saintentropy