-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position node autocomplete UI against respective input port #11190
Position node autocomplete UI against respective input port #11190
Conversation
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
@aparajit-pratap looking great! 🙌 Can we simply change the initializing width to be 256 by default, then pick up actual width? Or is this only in one isolated case and could be different for other ones? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aparajit-pratap Would you try https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml#L10? They may end up both working but I think limiting on the control itself may be cleaner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aparajit-pratap LGTM
Purpose
https://jira.autodesk.com/browse/DYN-3174
Attempt at placing the node autocomplete UI aligned with the respective port.
This works as expected except for the first time you bring up the UI, for some reason. As can be seen in the gif, the first time, the UI is not spaced correctly from the port. It was observed that the reason for this is that the
ActualWidth
of the control is 250 the first time and subsequently it is 256. I'm not sure why this is the case 😕Declarations
Check these if you believe they are true
*.resx
filesFYIs
@Amoursol