Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position node autocomplete UI against respective input port #11190

Merged
merged 11 commits into from
Oct 20, 2020

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Oct 19, 2020

Purpose

https://jira.autodesk.com/browse/DYN-3174

Attempt at placing the node autocomplete UI aligned with the respective port.

This works as expected except for the first time you bring up the UI, for some reason. As can be seen in the gif, the first time, the UI is not spaced correctly from the port. It was observed that the reason for this is that the ActualWidth of the control is 250 the first time and subsequently it is 256. I'm not sure why this is the case 😕

place_autocomplete_ui

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

FYIs

@Amoursol

@aparajit-pratap aparajit-pratap changed the title Auto complete ui Position Node autocomplete UI against respective input port Oct 19, 2020
@aparajit-pratap aparajit-pratap changed the title Position Node autocomplete UI against respective input port Position node autocomplete UI against respective input port Oct 19, 2020
@Amoursol
Copy link
Contributor

@aparajit-pratap looking great! 🙌

Can we simply change the initializing width to be 256 by default, then pick up actual width? Or is this only in one isolated case and could be different for other ones?

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang
Copy link
Contributor

@aparajit-pratap Would you try https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml#L10? They may end up both working but I think limiting on the control itself may be cleaner

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aparajit-pratap aparajit-pratap merged commit a23cbe7 into DynamoDS:master Oct 20, 2020
@aparajit-pratap aparajit-pratap deleted the autoCompleteUI branch October 20, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants