Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Dispose() calls in Shutdown() #11054

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Skip Dispose() calls in Shutdown() #11054

merged 2 commits into from
Aug 25, 2020

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Aug 25, 2020

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

As a follow up of #10672. @mmisol found all Dispose() functions are called twice and I verified that it is indeed the case. So I am removing these dedicated calls to show extension authors that they will only need to implement Dispose() call in the future.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang requested a review from mmisol August 25, 2020 19:25
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment regarding these changes.

We should also update TuneUp and the NodePropertyPalette, right? Any other place we may have documented this? Like a View extension sample?

Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@QilongTang
Copy link
Contributor Author

@mmisol I checked our implementation in https://developer.dynamobim.org/03-Development-Options/3-6-extensions.html and https://github.com/DynamoDS/DynamoSamples/blob/master/src/SampleViewExtension/SampleViewExtension.cs is actually correct. I will make PRs for TuneUp

@QilongTang QilongTang merged commit 43842d6 into master Aug 25, 2020
@QilongTang QilongTang deleted the RemoveDisposeCalls branch August 25, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants