Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T1.4-Update ScriptEditorWindow #10930

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

SHKnudsen
Copy link
Contributor

@SHKnudsen SHKnudsen commented Jul 23, 2020

Purpose

This PR updates the Python ScriptEditor so buttons are aligned and only uses icons and tooltips.

T1 4-UpdatePythonScriptEditor

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@mmisol

FYIs

@mjkkirschner
@QilongTang
@radumg

@SHKnudsen SHKnudsen changed the title Update ScriptEditorWindow.xaml T1.4-Update ScriptEditorWindow Jul 23, 2020
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited. I have been waiting for this so I can propose the dock button using the same style

Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I guess I would put 2->3 and ? next to each other, as they are related, but not my call :)

@radumg
Copy link
Collaborator

radumg commented Jul 29, 2020

Ok, I'll bring that up at demo for @Amoursol to decide on placing, we can still change/rectify in the other PRs, but given it's been approved, merging this so it doesn't interfere with the other PRs.

@radumg radumg merged commit 4c27376 into DynamoDS:master Jul 29, 2020
@Amoursol
Copy link
Contributor

I'm totally happy with putting the ? next to the 2->3 button 😊

@radumg radumg mentioned this pull request Jul 31, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants