harden discovery of codeCompletionProvider. #10858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmisol
approved these changes
Jul 7, 2020
mmisol
reviewed
Jul 7, 2020
| { | ||
| return new Type[0]; | ||
| } | ||
| }).Where(p => completionType.IsAssignableFrom(p) && !p.IsInterface); |
There was a problem hiding this comment.
One thing we could add is an explicit call to ToList. I see loadedCodeCompletionTypes is used afterwards a couple of times.
There was a problem hiding this comment.
sure will do - I tested it manually.
zeusongit
approved these changes
Jul 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When search the appdomain for the CompletionProvider interfaces, if this linq statement encountered an exception it would bail out and fail to find the loaded completion providers. Now it does continues.
I could not figure out quick way to test this, if others believe this is required for this scenario I appreciate ideas.
Declarations
Check these if you believe they are true
*.resxfiles