Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle runtime table gaps on code block deletion #10605

Merged
merged 8 commits into from
May 4, 2020

Commits on Apr 27, 2020

  1. Handle runtime table gaps on code block deletion

    When the runtime table are built there is an implicit assumption that
    the code block ids are consecutive. However, that is not always the
    case, as the deletion of a procedure causes the deletion of its child
    code blocks, which may generate gaps in the id numbering.
    
    In order to make the code resiliant to these gaps, the runtime tables
    are sized based on the largest code block id, rather than in the amount
    of code blocks.
    mmisol committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    baed834 View commit details
    Browse the repository at this point in the history
  2. Remove commented out code

    mmisol committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    85f7232 View commit details
    Browse the repository at this point in the history
  3. Remove commented out code

    mmisol committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    c3bd236 View commit details
    Browse the repository at this point in the history
  4. Fix typo and improve comment

    mmisol committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    87b0284 View commit details
    Browse the repository at this point in the history
  5. Add test

    mmisol committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    7a45ab7 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Configuration menu
    Copy the full SHA
    f6343bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e331114 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    84b701b View commit details
    Browse the repository at this point in the history