DYN-2406: better handle pts/lines when selecting, freezing, and isolating. #10375

mjkkirschner · 2020-02-10T19:19:22Z

Purpose

PR does the following:

when geometry is isolated and selected, should appear normal based on previous state. This was not being done correctly for meshes - corrected this.
when geometry is isolated and unselected geometry should appear transparent.
when pts or lines are selected they should turn blue. - no longer are vertex colors blended with selection color - instead selection overrides the vertex colors.
when pts or lines are deselected they should return to their original colors. (which might be default or might be vertex colors) - or might be frozen (transparent).

updates:

modifies field of view of camera back to master - 58.5 degrees vs 45.
fixes background color of watch3d - grey and yellow when in a home workspace vs custom node workspace.
starts to add image comparison tests. WIP.

To accomplish this following was implemented:

adds a frozen material vs isolation material as these have different alpha levels.
when pts or lines colors are generated and DynamoGeometryModel is created when aggregating renderpackages we cache the original colors from the renderpackage on the HelixViewModel - later when some attached property is modified which requires reverting colors we can call reset colors which sets the colors to the old colors cached on the viewModel.
this lookup is done by tagging the DynamoGeometryModelPoint or Line with the id of the colors in the cache so we can do a fast lookup.
when an attached property changes which requires setting frozen or selected colors we generate those colors and set them to the vertex colors. The point and line materials in helix do not currently support the types of blending we would need to use them like we do for meshes - and in fact - it's not clear we can use those materials either- as we don't currently support vertex coloring of meshes yet. Next task.
when a selection change event occurs in the canvas and isolate mode is active - we set isolate attached property on all the Geometry3dModels - previously we also removed everything from the sceneItems collection and then re-added everything to kick off a render - this is no longer necessary and was very slow causing noticeable stutter on my system - removing it, the color and material updates propagate fine as far as I can tell and tests continue to pass - though hopefully we can add image comparison tests to validate this kind of thing even more robustly.

TODO

- more tests
at least one image comparison test.
refactor out repeated code

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@QilongTang
@reddyashish

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate.

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs

add cleanup to color cache

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs

QilongTang · 2020-02-12T07:14:51Z

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs

@@ -38,41 +117,84 @@ public static bool GetShowSelected(DependencyObject element)

        private static void ShowSelectedPropertyChanged(DependencyObject obj, DependencyPropertyChangedEventArgs args)


I got you now, thank you for these comments helping me to understand. The implementation here does seem breakable. Maybe we can create several function to color mesh/point&line in different condition-> isolate, frozen, selection because it seems we always need to go through these cases again and again.

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs

src/VisualizationTests/HelixWatch3DViewModelTests.cs

QilongTang · 2020-02-12T07:29:40Z

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs

@@ -156,6 +156,8 @@ public class HelixWatch3DViewModel : DefaultWatch3DViewModel
        private readonly Color4 defaultSelectionColor = new Color4(new Color3(0, 158.0f / 255.0f, 1.0f));
        private readonly Color4 defaultMaterialColor = new Color4(new Color3(1.0f, 1.0f, 1.0f));
        private readonly Color4 defaultTransparencyColor = new Color4(1.0f, 1.0f, 1.0f, 0.5f);
+        private readonly Color4 defaultIsolatedTransparencyColor = new Color4(1.0f, 1.0f, 1.0f, 0.3f);


Are these all defined by Dynamo team somehow?

@mjkkirschner where did you get the 0.3f from? Is it specified somewhere?

not that I could find, I just tried to match the existing look, where isolated geometry is more transparent than frozen geometry.

Looks like this value was originally set to 0.1f for lines and points: https://github.com/DynamoDS/Dynamo/pull/7587/files#diff-20b13dfe2f88aaf8df37e1240b79c201R30 and 0.2f.

@aparajit-pratap - thanks for finding this!

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs

fix watch3d background color test fix watch3d image export function

… function in helix does not work.

need to rerun tests

aparajit-pratap · 2020-02-18T16:34:49Z

when geometry is isolated and selected, should appear normal based on previous state. This was not being done correctly for meshes - corrected this.

I see that this is the current behavior but was wondering if it makes sense to turn it into selection color instead just like it does for frozen nodes.

mjkkirschner · 2020-02-18T18:08:39Z

when geometry is isolated and selected, should appear normal based on previous state. This was not being done correctly for meshes - corrected this.

I see that this is the current behavior but was wondering if it makes sense to turn it into selection color instead just like it does for frozen nodes.

I was thinking the same thing initially but decided on keeping the current behavior as it seems useful to be able to view the colors of the selected geometry, I can already use selection as a quick way to see which geometry is which but it does not help me to quickly see vertex colored geometry.

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs

aparajit-pratap · 2020-02-18T18:12:24Z

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs

@@ -156,6 +156,8 @@ public class HelixWatch3DViewModel : DefaultWatch3DViewModel
        private readonly Color4 defaultSelectionColor = new Color4(new Color3(0, 158.0f / 255.0f, 1.0f));
        private readonly Color4 defaultMaterialColor = new Color4(new Color3(1.0f, 1.0f, 1.0f));
        private readonly Color4 defaultTransparencyColor = new Color4(1.0f, 1.0f, 1.0f, 0.5f);
+        private readonly Color4 defaultIsolatedTransparencyColor = new Color4(1.0f, 1.0f, 1.0f, 0.3f);


@mjkkirschner where did you get the 0.3f from? Is it specified somewhere?

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs

all tests pass

aparajit-pratap · 2020-02-19T21:42:40Z

Aside from another comment about the alpha value chosen, LGTM.

reddyashish · 2020-02-19T23:43:58Z

LGTM.

mjkkirschner · 2020-02-20T19:34:56Z

meshes at 0.2f, pts and lines at 0.3f

meshes, points, and lines at .2f alpha

if we bring pts and lines down to .1f alpha as before they are completely invisible....

@aparajit-pratap @reddyashish @QilongTang what do you think?

QilongTang · 2020-02-20T20:05:59Z

@mjkkirschner These are light enough I think we can stick to the new values?

… no need to update scene items - modifying colors updates the materials and colors already.

mjkkirschner · 2020-02-20T20:19:50Z

new on the left
master on the right
using .25f for alpha for lines and points - @QilongTang and I think this is good. Will merge after running all visualization tests locally.

modify pt line isolation alpha

mjkkirschner · 2020-02-20T21:03:59Z

fixed latest color test additions for behavior on this branch - merging.

QilongTang · 2020-02-20T21:07:54Z

LGTM

aparajit-pratap · 2020-02-20T21:12:41Z

@mjkkirschner sorry, my previous comment was all jumbled up. I think it was set to 0.1f for meshes and 0.2f for points and lines earlier. Did you try these values and find them to appear to be too light?

mjkkirschner · 2020-02-20T21:21:54Z

@aparajit-pratap .2f was too light for points/lines (.25f looks good) - but I will try .1f for meshes and compare now before I merge.

mjkkirschner · 2020-02-20T21:25:14Z

I will keep it like this:
.1f for meshes - .25f for pts/lines.

* Move to Helix 2.5.1 and SharpDX 4.2.0 * Re-implement zoom in/out buttons * Upgrade Helix to 2.9.0 * Re-implement headlight outside of shader * Remove Helix shader pipeline customizations, use default shaders (WIP) * restore updating colors for selected and frozen node states * code cleanup * Use Viewport3DX.Items, enable geometry -> node selection * Helix upgrade basics (#10326) * [DYN-2349] Close workspace references extension tab by user action and API (#10230) * DYN-2349 * Adding events and fixing the crash that was happening due to selection/deselection of the menu item. * Change to internal * Moving the Close tab event from ViewLoadedParams to WorkspaceDependencyView call * Adding extension tab name as an input parameter to the Close Extension event * Adding null check for WorkspaceReferencesMenuItem * Making the extension name string a constant * Removing the extra line * Dyn 2303 (#10277) * Add Category ExcelTest. * Update ExcelTests.cs * Add new LibraryViewExtension project based on System.Windows.Controls.WebBrowser (#10241) * add new project add make core internals visible add duplicate files as required * build of libjswebview seems to work added package references * add resource files as links so dont duplicate them in repo * move to .net 4.7.2 to avoid package ref issues namespace adds dynamo use new namespace to reference resources that are embedded. * move back to 4.7 to see if we can get a build on self serve * log msbuild version in appyveyor * try using buildxml which restores a bit differently * image should not be under env - bah * revet back to nuget restore and build dynamo all * working branch in acad * icons from host registered streams supported now * this functions but startup time is slow. visibility fixed with startPage loads acad icons from resource streams that are registered using existing resource dict * add some stopwatch logging to resource loading remove superflous resourcestream handler add cache to main iconProvider entrypoint as first step in resolving icon data use string builder to construct base64 data strings * missed changes * semi working lazy load - small change made to librariejs to raise event whenever any item is clicked we also cache the original url before falling back to the default icon so we can load the real icon later. * some cleanup * update namespace to reflect what components are actually used update some todos update comments * drop back to packges config rename project, rename folder rename extension class * assembly and type names changed * remove value tuple use set version number to auto increment for now - keep at 1.0.x until we have a longer term plan for this project * get rid of value tuple * recase some methods comments add readme * address review comments * Add new tests (#10279) * Revert "Reset engine controller for every new workspace (#10113)" (#10282) This reverts commit b01e2de. * DYN-2375 - Event to handle the close operation of the workspace references extension (#10280) * First commit * new changes * Renaming the event * Adding test * Upgrade Revit Sample file to Revit 2021 (#10288) * pass the additional to sign list to the installerspec generator (#10285) add new files add comments remove files that no longer exist update installerSpec.exe update installerspec source * points and curves render bounds are updated when added - and faster than for each RP. remove new handlers and events, revert to binding. * revert change * remove commented out code * add comments * remove some old comments remove old code for testing Co-authored-by: reddyashish <[email protected]> Co-authored-by: manuelsaldivar525 <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: ZiyunShang <[email protected]> * Helix upgrade PR to merge the changes from the master branch (#10388) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <[email protected]> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * Update HelixWatch3DViewModelTests.cs * Updating Watch3D_Disconnect_Reconnect_CorrectRenderings test Co-authored-by: DynamoEngOps <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: StarLee <[email protected]> * [DYN-2341] Labels on helix-update branch cause slow down (#10399) * Fix the null pointer exception This will render the labels on the workspace without any lags. * Adding test to compare the performace. * Verify test run time. * some changes to the test. * Update comments * DYN-2406: better handle pts/lines when selecting, freezing, and isolating. (#10375) * working color change on selection for points. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * improve performance of selection handler while isolation mode is on - no need to update scene items - modifying colors updates the materials and colors already. * fix color tests modify pt line isolation alpha * fix alpha value for mesh colors in isolation mode. (#10405) * working color change on selection for points. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * improve performance of selection handler while isolation mode is on - no need to update scene items - modifying colors updates the materials and colors already. * fix color tests modify pt line isolation alpha * missed last alpha change * Helix upgrade mastermerge (#10465) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <[email protected]> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * add show line numbers when watermarkLabel is collapsed (#10362) * Visual Identifier on Optional Inputs (#10361) * change port text to italic if using default input * Update Ports.xaml * Update README.md (#10387) * Update README.md * Update README.md * Update README.md * Update DynamoVisualProgramming.Core.nuspec * Update DynamoVisualProgramming.Core.nuspec * GA client not launching when terms not agreed (#10407) * GA client not launching when terms not agreed * Comments * Patch 283 (#10421) * Add WinVerityTrust wrapper * Utilzie new WinTrustWrapper method for cert verification * Add negative test * Add Package with faked certificate * Create sub namespace for WinVerityInteropp * Update the WinTrustInterop * Upate method call name * Add specific exceptions to the CertificateVerfication class * formating * Cover Test for Configuration Folder (#10444) * Cover Test for Configuration Folder * Update DynamoCoreTests.csproj * Added a couple of asserts for the properties. (#10437) * Add Test for Properties and removed getter and setter from WorkspaceDependencyViewExtension.DependencyView property. * Update WorkspaceDependencyViewExtension.cs * Fix for crash while drawing Point manipulator (gizmo) when LibG fails to load (#10148) * fix for crash in DM when LibG fails to load * return from recursive loop once we find the first non-null point * cache enabled flag for manipulator * more fixes * add documentation * add documentation Co-authored-by: DynamoEngOps <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: StarLee <[email protected]> Co-authored-by: Sylvester Knudsen <[email protected]> * Mesh display using shaders (#10462) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <[email protected]> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * working color change on selection for points. * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * add show line numbers when watermarkLabel is collapsed (#10362) * Visual Identifier on Optional Inputs (#10361) * change port text to italic if using default input * Update Ports.xaml * Update README.md (#10387) * Update README.md * Update README.md * Update README.md * Update DynamoVisualProgramming.Core.nuspec * Update DynamoVisualProgramming.Core.nuspec * GA client not launching when terms not agreed (#10407) * GA client not launching when terms not agreed * Comments * Patch 283 (#10421) * Add WinVerityTrust wrapper * Utilzie new WinTrustWrapper method for cert verification * Add negative test * Add Package with faked certificate * Create sub namespace for WinVerityInteropp * Update the WinTrustInterop * Upate method call name * Add specific exceptions to the CertificateVerfication class * formating * fix summary * Cover Test for Configuration Folder (#10444) * Cover Test for Configuration Folder * Update DynamoCoreTests.csproj * Added a couple of asserts for the properties. (#10437) * Add Test for Properties and removed getter and setter from WorkspaceDependencyViewExtension.DependencyView property. * Update WorkspaceDependencyViewExtension.cs * this is working to link 2 simple shaders - they are just for testing though. (vertex shaders with lighting) embed testing shaders add technique that uses our 2 shaders add core and node classes for dynamo mesh which will set data on shader based on attached properties. * Fix for crash while drawing Point manipulator (gizmo) when LibG fails to load (#10148) * fix for crash in DM when LibG fails to load * return from recursive loop once we find the first non-null point * cache enabled flag for manipulator * more fixes * add documentation * add documentation * update shader names add handle mesh method to attached properties replacing all the material setting add code for setting bit flags and setting data on struct that actually makes it to shader add helix shader structs and functions that we need to compile our shaders add readme * fix broken tests dude to bad merge conflict fix * remove commented out vertex shader code * fix bug in shader fix comment and some todos * remove tested transofmrable interface * update comments * review comments * review comments2 Co-authored-by: DynamoEngOps <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: StarLee <[email protected]> Co-authored-by: Sylvester Knudsen <[email protected]> * Headlight bound to Camera LookDirection (#10466) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <[email protected]> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * working color change on selection for points. * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * add show line numbers when watermarkLabel is collapsed (#10362) * Visual Identifier on Optional Inputs (#10361) * change port text to italic if using default input * Update Ports.xaml * Update README.md (#10387) * Update README.md * Update README.md * Update README.md * Update DynamoVisualProgramming.Core.nuspec * Update DynamoVisualProgramming.Core.nuspec * GA client not launching when terms not agreed (#10407) * GA client not launching when terms not agreed * Comments * Patch 283 (#10421) * Add WinVerityTrust wrapper * Utilzie new WinTrustWrapper method for cert verification * Add negative test * Add Package with faked certificate * Create sub namespace for WinVerityInteropp * Update the WinTrustInterop * Upate method call name * Add specific exceptions to the CertificateVerfication class * formating * fix summary * Cover Test for Configuration Folder (#10444) * Cover Test for Configuration Folder * Update DynamoCoreTests.csproj * Added a couple of asserts for the properties. (#10437) * Add Test for Properties and removed getter and setter from WorkspaceDependencyViewExtension.DependencyView property. * Update WorkspaceDependencyViewExtension.cs * this is working to link 2 simple shaders - they are just for testing though. (vertex shaders with lighting) embed testing shaders add technique that uses our 2 shaders add core and node classes for dynamo mesh which will set data on shader based on attached properties. * Fix for crash while drawing Point manipulator (gizmo) when LibG fails to load (#10148) * fix for crash in DM when LibG fails to load * return from recursive loop once we find the first non-null point * cache enabled flag for manipulator * more fixes * add documentation * add documentation * update shader names add handle mesh method to attached properties replacing all the material setting add code for setting bit flags and setting data on struct that actually makes it to shader add helix shader structs and functions that we need to compile our shaders add readme * fix broken tests dude to bad merge conflict fix * remove commented out vertex shader code * fix bug in shader fix comment and some todos * remove tested transofmrable interface * update comments * fix binding add test * flip normal if back facing tri update shader * make sure compiled shader up to date. Co-authored-by: DynamoEngOps <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: StarLee <[email protected]> Co-authored-by: Sylvester Knudsen <[email protected]> * special render packages should render with materials colors only (#10481) * special render packages should render with materials add test update shader * fix comment * update comments * Update ProtoGeometry.config (#10483) * Avoid rendering Gizmo multiple times on rotate (#10479) A change of behavior in helix when upgrading from v2015 is that the CameraChanged event gets fired several times, once for each individual property of Camera that changed. In order to avoid rendering the Gizmo several times, which leads to choppy camera rotation, we limit the rendering of the Gizmo to only be done when the position of the camera changed. Use C# 6 to support build machines * add 3d graphics image comparison tests (#10487) * special render packages should render with materials add test update shader * fix comment * update comments * lower intensity of directional light add new image comp tests add new color dyn files that are easy to modify on the fly add first set of reference images * add new tests add ref images all pass local * comment * refactor tests correct comment * unused usings * target shader model 4 to avoid crash when user does not have GPU. (#10497) * special render packages should render with materials add test update shader * fix comment * update comments * lower intensity of directional light add new image comp tests add new color dyn files that are easy to modify on the fly add first set of reference images * add new tests add ref images all pass local * comment * drop to shader model 4 to avoid crash on WARP devices * fix shader interpolation and make image comparison tests more tolerant. (#10506) * add debug save image mode add percent diff assertion add log of percent and each diff * enable save fix build errors fix path errors * update shaders to fix them on WARP/real hardware remove dynamo ps input add color distance and percent dist check to make tests more tolerant of changes * rename function, rename params * Handle memory outage on render (cherry pick) (#10569) This brings the fix from master to the helix-upgrade branch. The only difference is that the test now mocks the AggregateRenderPackage function directly, because the function mocked in master no longer exists. The visibility was changed to internal virtual in order to be able to mock it, also using InternalsVisibleTo. * Add Image Comparison Test for Surface. (#10579) * Added Surface image comparison test and corrected indentation * Update to include .sat file * Format code lines * Remove Dup entry * Comments * Comments * Comments * Revert test file name change Co-authored-by: Michael Dewberry <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: michael kirschner <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: manuelsaldivar525 <[email protected]> Co-authored-by: ZiyunShang <[email protected]> Co-authored-by: DynamoEngOps <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: StarLee <[email protected]> Co-authored-by: Sylvester Knudsen <[email protected]> Co-authored-by: Martin Misol Monzo <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]>

mjkkirschner added 4 commits January 29, 2020 18:33

working color change on selection for points.

a90282a

lots of cleanup work to do but this works

cf32f8d

isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate.

start adding morecolor tests

df13bfd

fix test

5884a2f

mjkkirschner added the WIP label Feb 10, 2020

mjkkirschner requested review from reddyashish and QilongTang February 10, 2020 21:34

mjkkirschner commented Feb 10, 2020

View reviewed changes

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs Outdated Show resolved Hide resolved

add more tests

ff17767

add cleanup to color cache

mjkkirschner added the PTAL Please Take A Look 👀 label Feb 11, 2020

QilongTang reviewed Feb 12, 2020

View reviewed changes

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs Outdated Show resolved Hide resolved

QilongTang reviewed Feb 12, 2020

View reviewed changes

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs Outdated Show resolved Hide resolved

QilongTang reviewed Feb 12, 2020

View reviewed changes

src/VisualizationTests/HelixWatch3DViewModelTests.cs Show resolved Hide resolved

QilongTang reviewed Feb 12, 2020

View reviewed changes

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs Show resolved Hide resolved

QilongTang reviewed Feb 12, 2020

View reviewed changes

src/DynamoCoreWpf/ViewModels/Watch3D/HelixWatch3DViewModel.cs Show resolved Hide resolved

mjkkirschner added 4 commits February 12, 2020 19:36

fix watch3d background color converter

51588ef

fix watch3d background color test fix watch3d image export function

need to move branches - saving work

08963fb

give up on image comparison tests, will file that as followup, resize…

d792353

… function in helix does not work.

break out some util methods

dec8631

need to rerun tests

mjkkirschner added Graphics PTAL Please Take A Look 👀 and removed PTAL Please Take A Look 👀 WIP labels Feb 13, 2020

aparajit-pratap reviewed Feb 18, 2020

View reviewed changes

aparajit-pratap changed the title ~~WIP - better handle pts/lines when selecting, freezing, and isolating.~~ WIP - DYN-2406: better handle pts/lines when selecting, freezing, and isolating. Feb 18, 2020

QilongTang reviewed Feb 18, 2020

View reviewed changes

src/DynamoCoreWpf/ViewModels/Watch3D/AttachedProperties.cs Outdated Show resolved Hide resolved

Merge branch 'helix-upgrade' into ptLineColors

d2621f2

mjkkirschner changed the title ~~WIP - DYN-2406: better handle pts/lines when selecting, freezing, and isolating.~~ DYN-2406: better handle pts/lines when selecting, freezing, and isolating. Feb 18, 2020

mjkkirschner added 3 commits February 18, 2020 15:26

review comments

3e5dd95

all tests pass

Merge remote-tracking branch 'origin/ptLineColors' into ptLineColors

f7abe13

review comment

1915b79

QilongTang added LGTM Looks good to me and removed PTAL Please Take A Look 👀 labels Feb 20, 2020

improve performance of selection handler while isolation mode is on -…

0aeecb4

… no need to update scene items - modifying colors updates the materials and colors already.

fix color tests

1906928

modify pt line isolation alpha

reddyashish approved these changes Feb 20, 2020

View reviewed changes

mjkkirschner merged commit 7749e31 into DynamoDS:helix-upgrade Feb 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DYN-2406: better handle pts/lines when selecting, freezing, and isolating. #10375

DYN-2406: better handle pts/lines when selecting, freezing, and isolating. #10375

mjkkirschner commented Feb 10, 2020 •

edited

Loading

QilongTang Feb 12, 2020 •

edited

Loading

QilongTang Feb 12, 2020

aparajit-pratap Feb 18, 2020

mjkkirschner Feb 18, 2020

aparajit-pratap Feb 19, 2020 •

edited

Loading

mjkkirschner Feb 20, 2020

aparajit-pratap commented Feb 18, 2020 •

edited

Loading

mjkkirschner commented Feb 18, 2020

aparajit-pratap Feb 18, 2020

aparajit-pratap commented Feb 19, 2020

reddyashish commented Feb 19, 2020

mjkkirschner commented Feb 20, 2020

QilongTang commented Feb 20, 2020

mjkkirschner commented Feb 20, 2020

mjkkirschner commented Feb 20, 2020

QilongTang commented Feb 20, 2020

aparajit-pratap commented Feb 20, 2020

mjkkirschner commented Feb 20, 2020 •

edited

Loading

mjkkirschner commented Feb 20, 2020

		@@ -38,41 +117,84 @@ public static bool GetShowSelected(DependencyObject element)

		private static void ShowSelectedPropertyChanged(DependencyObject obj, DependencyPropertyChangedEventArgs args)

DYN-2406: better handle pts/lines when selecting, freezing, and isolating. #10375

DYN-2406: better handle pts/lines when selecting, freezing, and isolating. #10375

Conversation

mjkkirschner commented Feb 10, 2020 • edited Loading

Purpose

updates:

TODO

Declarations

Reviewers

FYIs

QilongTang Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

QilongTang Feb 12, 2020

Choose a reason for hiding this comment

aparajit-pratap Feb 18, 2020

Choose a reason for hiding this comment

mjkkirschner Feb 18, 2020

Choose a reason for hiding this comment

aparajit-pratap Feb 19, 2020 • edited Loading

Choose a reason for hiding this comment

mjkkirschner Feb 20, 2020

Choose a reason for hiding this comment

aparajit-pratap commented Feb 18, 2020 • edited Loading

mjkkirschner commented Feb 18, 2020

aparajit-pratap Feb 18, 2020

Choose a reason for hiding this comment

aparajit-pratap commented Feb 19, 2020

reddyashish commented Feb 19, 2020

mjkkirschner commented Feb 20, 2020

QilongTang commented Feb 20, 2020

mjkkirschner commented Feb 20, 2020

mjkkirschner commented Feb 20, 2020

QilongTang commented Feb 20, 2020

aparajit-pratap commented Feb 20, 2020

mjkkirschner commented Feb 20, 2020 • edited Loading

mjkkirschner commented Feb 20, 2020

mjkkirschner commented Feb 10, 2020 •

edited

Loading

QilongTang Feb 12, 2020 •

edited

Loading

aparajit-pratap Feb 19, 2020 •

edited

Loading

aparajit-pratap commented Feb 18, 2020 •

edited

Loading

mjkkirschner commented Feb 20, 2020 •

edited

Loading