Add ability to hide IsUsageReportingApproved and #10217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2019 15:18
QilongTang
reviewed
Dec 13, 2019
So it can't be modified outside the constructor but still accessible by WPF
|
@DmytroMuravskyi Thank you for the updates, exactly what I was worried before. These looks good. Merging |
QilongTang
pushed a commit
that referenced
this pull request
Dec 13, 2019
* Add ability to hide IsUsageReportingApproved and IsAnalyticsReportingApproved from Dynamo UI * Move HideReportOptions to DynamoViewModel * Move HideReportOptions to StartConfiguration * Make HideReportOptions public and readonly So it can't be modified outside the constructor but still accessible by WPF
7 tasks
QilongTang
added a commit
that referenced
this pull request
Dec 13, 2019
* Add ability to hide IsUsageReportingApproved and IsAnalyticsReportingApproved from Dynamo UI * Move HideReportOptions to DynamoViewModel * Move HideReportOptions to StartConfiguration * Make HideReportOptions public and readonly So it can't be modified outside the constructor but still accessible by WPF
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… IsAnalyticsReportingApproved from Dynamo UI
Purpose
Alias team needs a way to suppress the data reporting from UI, so it can be controlled by Alias.
The property controls visibility of 2 menu items and prevents report window from being shown during first run.
The HideReportOptions may suitable in DynamoViewModel.StartConfiguration but for comparability reasons I decided to add it only as a property for now.
Would be good if this change goes into 2.5 since this is target version for integrators.
Reviewers
@mjkkirschner