Packagepaths issues (#11793)

* small adjustment * align titles * add names to buttons for ui automation tests * missing button name * add dispose to packagepathview remove unused constructor raise can execute change when paths are shifted to update icons give pathview a name dispose package paths on prefs window close Co-authored-by: michael kirschner <[email protected]>
DynamoDS · Jun 25, 2021 · 56b9e57 · 56b9e57
1 parent 56fc0bd
commit 56b9e57
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/src/DynamoCoreWpf/ViewModels/PackageManager/PackagePathViewModel.cs b/src/DynamoCoreWpf/ViewModels/PackageManager/PackagePathViewModel.cs
@@ -162,6 +162,8 @@ private void SwapPath(int x, int y)
             var tempPath = RootLocations[x];
             RootLocations[x] = RootLocations[y];
             RootLocations[y] = tempPath;
+
+            RaiseCanExecuteChanged();
         }
 
         private void InsertPath()

diff --git a/src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml b/src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml
@@ -737,7 +737,7 @@
                                               ToolTip="{Binding Path=SelectedPackagePathForInstall}">
                                     </ComboBox>
                                     <ScrollViewer Height="200" VerticalScrollBarVisibility="Auto">
-                                        <packagemanager:PackagePathView DataContext="{Binding PackagePathsViewModel}"/>
+                                        <packagemanager:PackagePathView x:Name="PackagePathView" DataContext="{Binding PackagePathsViewModel}"/>
                                     </ScrollViewer>
                                 </StackPanel>
                             </Expander>

diff --git a/src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs b/src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs
@@ -86,6 +86,7 @@ private void CloseButton_Click(object sender, RoutedEventArgs e)
                 Actions.Close,
                 Categories.Preferences);
             viewModel.PackagePathsViewModel.SaveSettingCommand.Execute(null);
+            PackagePathView.Dispose();
             Close();
         }
 

diff --git a/src/DynamoCoreWpf/Views/PackageManager/PackagePathView.xaml.cs b/src/DynamoCoreWpf/Views/PackageManager/PackagePathView.xaml.cs
@@ -29,14 +29,9 @@ public PackagePathView()
             DataContextChanged += PackagePathView_DataContextChanged;
         }
 
-        internal PackagePathView(PackagePathViewModel viewModel)
+        internal void Dispose()
         {
-            if (viewModel == null)
-                throw new ArgumentNullException("viewModel");
-
-            InitializeComponent();
-            this.DataContext = viewModel;
-            viewModel.RequestShowFileDialog += OnRequestShowFileDialog;
+            ViewModel.RequestShowFileDialog -= OnRequestShowFileDialog;
         }
 
         #endregion