Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithy4s Build Settings #95

Closed
wants to merge 2 commits into from
Closed

Smithy4s Build Settings #95

wants to merge 2 commits into from

Conversation

bpholt
Copy link
Member

@bpholt bpholt commented Oct 7, 2024

These changes, in conjunction with the smithy4s codegen plugin changes suggested in disneystreaming/smithy4s#1590, should let us revert the build overrides made in #92. (We'll actually revert those changes once the smithy4s changes have been merged and published.)

bpholt added 2 commits October 7, 2024 12:03
…ciesAsJars because it seems like the more appropriate level of granularity for the setting we're modifying
since this module is unpublished, the version shouldn't matter outside
this project's build, and having a stable version will avoid cache
invalidation issues in the smithy4s codegen plugin.
@bpholt bpholt self-assigned this Oct 7, 2024
@bpholt bpholt requested a review from a team as a code owner October 7, 2024 17:10
@bpholt
Copy link
Member Author

bpholt commented Oct 9, 2024

I'm incorporating this into #96.

@bpholt bpholt closed this Oct 9, 2024
@bpholt bpholt deleted the smithy4s-build-settings branch October 9, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant