use a CQL query to narrow down the EC2 instances returned by listContainerInstances when searching by instance ID #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainerInstances when searching by instance ID this should dramatically reduce the number of ListContainerInstances, DescribeContainerInstances, ListTasks, and DescribeTasks calls made by the Draining lambda.
bpholt
commented
Dec 6, 2023
| @@ -27,6 +27,9 @@ object TaskCount extends NewtypeWrapped[Long] { | |||
| given Order[TaskCount] = Order[Long].contramap(_.value) | |||
| } | |||
|
|
|||
| type CQLQuery = CQLQuery.Type | |||
| object CQLQuery extends NewtypeWrapped[String] | |||
There was a problem hiding this comment.
If we had more query types to support, it might be worth writing a simple parser or some other more elaborate representation, but I think this is good enough for now.
benpjackson
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should dramatically reduce the number of
ListContainerInstances,DescribeContainerInstances,ListTasks, andDescribeTaskscalls made by the Draining lambda.