Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade log4j-slf4j-impl to 2.21.1 to avoid transitive update of slf4j-api #145

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

bpholt
Copy link
Member

@bpholt bpholt commented Dec 6, 2023

I think this is a bug in log4j-slf4j-impl v2.22.0; my understanding is that the artifact that should pull in slf4j 2.x is named log4j-slf4j2-impl. This causes messages like

SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
SLF4J: Ignoring binding found at [jar:file:/var/task/lib/org.apache.logging.log4j.log4j-slf4j-impl-2.22.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]

in the Lambda logs. Downgrading so that slf4j 1.x is used should result in logs being correctly emitted when our Lambdas run.

@bpholt bpholt self-assigned this Dec 6, 2023
@bpholt bpholt requested a review from a team as a code owner December 6, 2023 01:02
@bpholt bpholt merged commit e4abe83 into main Dec 6, 2023
4 checks passed
@bpholt bpholt deleted the logging branch December 6, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants