Add X-Ray Tracing using Natchez (attempt 2) #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this uses the X-Ray backend directly instead of using OTel, because AWS Lambda supports X-Ray by default, and including an OTel collector is extra work. It sounds like including the collector can be done by building it in as a Lambda Layer, but that's not something I've done before, and I think this will work for now.
…he 64KB X-Ray segment size limitation
gorskilauren
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #137, but this time we're only capturing the inputs used to call AWS APIs and not attaching the responses to the traces. X-Ray has a 64KB maximum segment size, and previously the traces were too big to be sent successfully to X-Ray.
(See also typelevel/natchez#925.)