Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finagle-thrift, util-core to 22.4.0 #46

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

scala-steward
Copy link
Contributor

Updates

from 22.3.0 to 22.4.0.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (22.3.0).
You might want to review and update them manually.

scalafix/input/src/main/scala/example/thrift/SimpleRequest.scala
scalafix/input/src/main/scala/example/thrift/SimpleResponse.scala
scalafix/input/src/main/scala/example/thrift/SimpleService$FinagleClient.scala
scalafix/input/src/main/scala/example/thrift/SimpleService$FinagleService.scala
scalafix/input/src/main/scala/example/thrift/SimpleService.scala
scalafix/output/src/main/scala/example/thrift/SimpleRequest.scala
scalafix/output/src/main/scala/example/thrift/SimpleResponse.scala
scalafix/output/src/main/scala/example/thrift/SimpleService$FinagleClient.scala
scalafix/output/src/main/scala/example/thrift/SimpleService$FinagleService.scala
scalafix/output/src/main/scala/example/thrift/SimpleService.scala
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.twitter" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "com.twitter" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

@mergify mergify bot requested a review from bpholt April 20, 2022 04:12
bpholt added 2 commits April 20, 2022 12:08
also moves the generated code to input/src_managed, so that the scripts
can differentiate between the generated and manually-written inputs
@bpholt bpholt self-assigned this Apr 20, 2022
@bpholt bpholt requested review from atoivonen, DhruvPhumbhra and henryxparker and removed request for bpholt April 20, 2022 17:44
@mergify mergify bot requested a review from bpholt April 20, 2022 17:45
Copy link
Member

@bpholt bpholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty minimal change since AFAICT there were no upstream changes in the new Finagle, Twitter Utils, or Scrooge release, but I did fix a small bug in the regenerate-inputs.sh script that I use when those dependencies are updated.

@mergify mergify bot merged commit ae07ddb into Dwolla:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants