Publish version-specific jars for all supported Twitter versions #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also publishes unsuffixed "latest" jars that are empty, but depend on the suffixed jar for the latest supported Twitter version
henryxparker
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also publishes unsuffixed "latest" jars that are empty, but depend on the suffixed jar for the latest supported Twitter version.
This will let our scrooge-importer plugin always pull in the suffixed version, but also let users who want to "float" versions use the unsuffixed versions.
Implementing the "latest" jars by publishing an empty jar with a dependency on the suffixed version has the additional benefit of avoiding any classpath clashes that would otherwise be caused by pulling in the "latest" jar and also the (correct) suffixed jar. Clever idea suggested by @JD557 and @armanbilge on the Scala Discord.