-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Dwolla/async-utils-twitter back into Dwolla/async-utils #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are published from the original repo
… and case classes
TracedThriftServer will accept incoming requests with attached Zipkin trace IDs and provide them to a given Natchez EntryPoint
Update cats-effect to 3.4.1
Update natchez-core to 0.2.1
Update sbt-scalajs to 1.12.0
update README to reflect splitting the repos
Update natchez-core to 0.2.2
without this, mimaPreviousArtifacts includes these projects in bincompat checks, which fail since these projects don't have published artifacts
Update cats-effect to 3.4.2
support 128-bit Trace IDs when converting TraceIds and Kernels
Update sbt to 1.8.1
Update cats-effect to 3.4.4
…er Utils releases
…se sbt-projectmatrix sets up individual projects for each supported Scala version
Update cats-effect to 3.4.11
Update sbt to 1.8.3
Executed command: sbt githubWorkflowGenerate
…in Dwolla/async-utils-twitter" This reverts commit eb72a71.
henryxparker
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
DhruvPhumbhra
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we changed the strategy for tracking Twitter ecosystem releases in Dwolla/async-utils-twitter#39, we don't need to release new major versions of the Twitter async-utils artifacts each time we want to update Twitter libraries. That was the primary reason we split the repos, so since it no longer applies, it probably makes sense to recombine the libraries in a single project.