Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Dwolla/async-utils-twitter back into Dwolla/async-utils #114

Merged
merged 93 commits into from
May 24, 2023
Merged

Conversation

bpholt
Copy link
Member

@bpholt bpholt commented May 16, 2023

Since we changed the strategy for tracking Twitter ecosystem releases in Dwolla/async-utils-twitter#39, we don't need to release new major versions of the Twitter async-utils artifacts each time we want to update Twitter libraries. That was the primary reason we split the repos, so since it no longer applies, it probably makes sense to recombine the libraries in a single project.

bpholt and others added 30 commits November 15, 2022 12:09
TracedThriftServer will accept incoming requests with attached Zipkin trace IDs and provide them to a given Natchez EntryPoint
update README to reflect splitting the repos
without this, mimaPreviousArtifacts includes these projects in bincompat
checks, which fail since these projects don't have published artifacts
support 128-bit Trace IDs when converting TraceIds and Kernels
@bpholt bpholt self-assigned this May 16, 2023
@bpholt bpholt requested a review from a team as a code owner May 16, 2023 16:33
Copy link

@henryxparker henryxparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@DhruvPhumbhra DhruvPhumbhra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants