correct remaining warnings

Dwolla · Mar 14, 2024 · 90ad4f1 · 90ad4f1
1 parent 18820d3
commit 90ad4f1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/TracedThriftClient.scala b/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/TracedThriftClient.scala
@@ -11,8 +11,6 @@ import com.dwolla.util.async.twitter._
 import com.twitter.util.{Closable, Future}
 import natchez.Trace
 
-import scala.language.reflectiveCalls
-
 /**
  * Build a Finagle Thrift client using the given Thrift
  * method-per-endpoint algebra and the given destination. Optionally,
@@ -40,7 +38,7 @@ object TracedThriftClient {
    */
   def apply[Alg[_[_]] <: AnyRef {def asClosable: Closable}] = new PartiallyAppliedThriftClient[Alg]()
 
-  class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[TracedThriftClient](val dummy: Unit = ()) extends AnyVal {
+  class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[TracedThriftClient](val dummy: Boolean = false) extends AnyVal {
     /**
      * @param name the local service name to be set on the Zipkin tracer
      * @param dest the destination whence the Thrift interface is being served.

diff --git a/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/ZipkinTracer.scala b/finagle-natchez/src/main/scala/com/dwolla/util/async/finagle/ZipkinTracer.scala
@@ -47,9 +47,9 @@ class ZipkinTracerConfig(val host: SocketAddress[_],
     this(
       SocketAddress(host"127.0.0.1", port"9411"),
       alwaysSample,
-      false,
+      tlsEnabled = false,
       localServiceName,
-      true,
+      compressionEnabled = true,
       "zipkin",
       "/api/v2/spans"
     )

diff --git a/twitter-finagle/src/main/scala/com/dwolla/util/async/finagle/ThriftClient.scala b/twitter-finagle/src/main/scala/com/dwolla/util/async/finagle/ThriftClient.scala
@@ -8,12 +8,10 @@ import com.dwolla.util.async.twitter._
 import com.twitter.finagle.Thrift
 import com.twitter.util.{Closable, Future}
 
-import scala.language.reflectiveCalls
-
 object ThriftClient {
   def apply[Alg[_[_]] <: AnyRef {def asClosable: Closable}] = new PartiallyAppliedThriftClient[Alg]()
 
-  class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[ThriftClient] (val dummy: Unit = ()) extends AnyVal {
+  class PartiallyAppliedThriftClient[Alg[_[_]] <: AnyRef {def asClosable: Closable}] private[ThriftClient] (val dummy: Boolean = false) extends AnyVal {
     def apply[G[_] : Async](dest: String)
                            (implicit
                             AlgR: Alg[ReaderT[Future, Alg[Future], *]],