-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle URL encoding/decoding #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #110 will degrade performances by 29.73%Comparing Summary
Benchmarks breakdown
|
CathalMullan
force-pushed
the
8-investigate-url-encodingdecoding
branch
4 times, most recently
from
August 19, 2024 14:28
60cad2e
to
a2868e7
Compare
CathalMullan
force-pushed
the
8-investigate-url-encodingdecoding
branch
2 times, most recently
from
August 19, 2024 14:48
5dbb6a4
to
b3ea7bd
Compare
CathalMullan
force-pushed
the
8-investigate-url-encodingdecoding
branch
from
August 19, 2024 15:12
b3ea7bd
to
dfe83cf
Compare
CathalMullan
force-pushed
the
8-investigate-url-encodingdecoding
branch
from
August 19, 2024 18:07
dc3b3a0
to
18e1b63
Compare
CathalMullan
force-pushed
the
8-investigate-url-encodingdecoding
branch
from
August 19, 2024 19:52
afb8b9d
to
75ab007
Compare
CathalMullan
force-pushed
the
8-investigate-url-encodingdecoding
branch
from
August 19, 2024 19:53
75ab007
to
4f5cece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy path works well.
Need to think about the use of unsafe in fetching parameters.
We want to avoid duplicate UTF-8 safety checks.
With out current approach, we could just have 2 methods for searching. Then we'd cut out the if statement per search.
API isn't set in stone. Keep it as is for now?
Issue with the Path API is that if we try to search decoded, then search non-decoded, we'll use the decoded version.
Maybe force everyone through the encoded path?
How would that work for HTTP-adjacent use cases? Like gRPC (Tonic)?
EDIT: Removed regex. Wasn't confident in the implementation.
Marking this implementation as 'good enough' for now.
Not like I'm releasing this code yet, anyways.
Just need to add more tests to showcase nuances in encoding specs.