Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for format_odometer #91

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Add tests for format_odometer #91

merged 2 commits into from
Oct 15, 2021

Conversation

DurgNomis-drol
Copy link
Owner

No description provided.

@DurgNomis-drol DurgNomis-drol requested a review from joro75 October 15, 2021 18:03
joro75
joro75 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@joro75 joro75 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks. It wasn't clear to me what kind of conversion the format_odometer function was doing. Now it is clear!

@DurgNomis-drol
Copy link
Owner Author

Yeah, got a lot of information in my head that i probably should write down and document somewhere 😆

And thanks!

@DurgNomis-drol DurgNomis-drol merged commit 033898f into master Oct 15, 2021
@DurgNomis-drol DurgNomis-drol deleted the tests-format-odometer branch October 15, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joro75 joro75 joro75 approved these changes

Assignees
No one assigned
Labels
🔧 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DurgNomis-drol @joro75 @CM000n