Add tests for Energy #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joro75
approved these changes
Oct 15, 2021
|
@joro75 That was the goal. It was getting harder and harder to make sure no bugs slipped in every time I added a new feature or supported a new model. 😃 |
|
Yes, that is also one of the advantages of having unittests. It shows/explains what the code is doing, and what the expected outcome of the code-function is. |
|
I have never used unittests before and it was a daunting task to start learning it. The next one is for HVAC data, but that is also pretty complicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add some important tests that covers scenarios where different combinations of data is available.