Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for sensors.py and adds pytest as as pre-commit hook #84

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Add tests for sensors.py and adds pytest as as pre-commit hook #84

merged 2 commits into from
Oct 15, 2021

Conversation

DurgNomis-drol
Copy link
Owner

No description provided.

@DurgNomis-drol DurgNomis-drol marked this pull request as draft October 12, 2021 20:04
@joro75 joro75 mentioned this pull request Oct 14, 2021
Closed
@DurgNomis-drol DurgNomis-drol marked this pull request as ready for review October 15, 2021 11:22
@DurgNomis-drol DurgNomis-drol requested a review from joro75 October 15, 2021 11:25
joro75
joro75 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@joro75 joro75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Those are indeed a lot of good tests!
Also good that you already moved some class variables to instance variables!!

@joro75 joro75 merged commit 794b6f3 into master Oct 15, 2021
@DurgNomis-drol DurgNomis-drol deleted the add-tests branch October 15, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joro75 joro75 joro75 approved these changes

Assignees
No one assigned
Labels
🔧 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DurgNomis-drol @joro75 @CM000n