Enhancement: Add logging on api endpoints #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 71.28% 71.01% -0.27%
==========================================
Files 28 30 +2
Lines 1386 1432 +46
==========================================
+ Hits 988 1017 +29
- Misses 398 415 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GitOldGrumpy
approved these changes
Jan 13, 2024
CM000n
deleted the
enhancement/implement_logging_information_for_endpoint_responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite helpful to have a logging option to compare endpoint responses and parsed models.
The
hishelandhttpxpackages provide information by default whenloggingis enabled. This PR complements therefore the logging for parsed pydantic models of api responses and introduces a central logging config.