Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make dcm and electricalPlatformCode optional #285

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Jan 9, 2024

Make dcm and electricalPlatformCode optional according to #284

@CM000n CM000n self-assigned this Jan 9, 2024
@CM000n CM000n added the 🐛 bug label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9895806) 72.47% compared to head (91ec4f5) 72.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   72.47%   72.47%           
=======================================
  Files          28       28           
  Lines        1355     1355           
=======================================
  Hits          982      982           
  Misses        373      373           
Flag Coverage Δ
unittests 72.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CM000n CM000n linked an issue Jan 9, 2024 that may be closed by this pull request
@CM000n CM000n merged commit a655590 into master Jan 9, 2024
25 checks passed
@CM000n CM000n deleted the fix/make_dcm_and_electricplatformcode_optional branch January 9, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected value returned by Toyota
2 participants