Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inconsistency in statistics summaries #282

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

GitOldGrumpy
Copy link
Collaborator

@GitOldGrumpy GitOldGrumpy commented Jan 8, 2024

Fix issue: #281

  • Fix for double addition for first item in a year
  • Fix for only single month being returned in a year summary
  • Fix for no data being returned. This happens when there has no been "driving" days in the date range requested.

- Fix for only single month being returned in a year summary
- Fix for no data being returned. This happens when there has no been "driving" days in the date range requested.
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9895806) 72.47% compared to head (9e52bba) 72.36%.
Report is 3 commits behind head on master.

Files Patch % Lines
mytoyota/models/vehicle.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   72.47%   72.36%   -0.11%     
==========================================
  Files          28       28              
  Lines        1355     1357       +2     
==========================================
  Hits          982      982              
- Misses        373      375       +2     
Flag Coverage Δ
unittests 72.36% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GitOldGrumpy GitOldGrumpy linked an issue Jan 8, 2024 that may be closed by this pull request
CM000n
CM000n previously approved these changes Jan 9, 2024
Copy link
Collaborator

@CM000n CM000n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

mytoyota/models/vehicle.py Show resolved Hide resolved
@CM000n CM000n added the 🐛 bug label Jan 9, 2024
@CM000n CM000n changed the title Fix issue 281 Fix: Inconsistency in statistics summaries Jan 9, 2024
@CM000n CM000n merged commit 66ad51e into master Jan 9, 2024
25 checks passed
@CM000n CM000n deleted the issue_281_incontinence_in_statistic branch January 9, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in statistics summaries
2 participants