Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix car door lock status #272

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix car door lock status #272

merged 2 commits into from
Jan 5, 2024

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Jan 4, 2024

I happened to notice today that the current approach for determining locked doors returns None for unlocked doors.
Toyota's API handles these things really strangely. 😕
Instead of setting the values for carstatus_locked to True and False accordingly, a separate carstatus_unlocked value is passed for unlocked doors.

@CM000n CM000n self-assigned this Jan 4, 2024
@CM000n CM000n added the 🐛 bug label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6e651ed) 72.46% compared to head (0d904d7) 72.47%.

Files Patch % Lines
mytoyota/models/lock_status.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   72.46%   72.47%           
=======================================
  Files          28       28           
  Lines        1351     1355    +4     
=======================================
+ Hits          979      982    +3     
- Misses        372      373    +1     
Flag Coverage Δ
unittests 72.47% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CM000n CM000n merged commit 70526ac into master Jan 5, 2024
25 checks passed
@CM000n CM000n deleted the fix/fix_car_door_lock_status branch January 5, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants