Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codecov.yml configuration file to relax approving PR #147

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

joro75
Copy link
Collaborator

@joro75 joro75 commented Feb 16, 2022

Provide a codecov configuration file that relaxes the codecov check that is required to approve the PR.
In the previous configuration a change of -0.01% of coverage blocked the pull request.
With this configuration a warning is only raised if the coverage is going 2% down. And because it is informational, it will still not block the actual PR.

Also see: https://docs.codecov.com/docs/common-recipe-list

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #147 (b2e7844) into master (4dc80e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          27       27           
  Lines        1325     1325           
=======================================
  Hits         1254     1254           
  Misses         71       71           
Flag Coverage Δ
unittests 94.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc80e5...b2e7844. Read the comment docs.

@joro75 joro75 mentioned this pull request Feb 16, 2022
Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, is 2% enough?

@joro75
Copy link
Collaborator Author

joro75 commented Feb 17, 2022

I don't know if 2% is enough. It was blocking the other PR, so I needed a little bit.
Also be aware it is an 'informal' check now, so it will not be blocking any PR. So even with a 10% decrease we will still be allowed to accept the PR.

@joro75 joro75 deleted the RelaxCodeCovPR branch February 17, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants