Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code tweaks and minor refactoring of the rest #134

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Code tweaks and minor refactoring of the rest #134

merged 3 commits into from
Jan 31, 2022

Conversation

DurgNomis-drol
Copy link
Owner

@DurgNomis-drol DurgNomis-drol commented Jan 31, 2022 •
edited
Loading

Nothing in here should be a breaking change except that the former get_uuid() in MyT object is now a property instead.

I also updated all the type annotations for this part to the modern standard as well.

You can now access the client object without importing it like mytoyota.client, now you can just use from mytoyota import Myt

@DurgNomis-drol DurgNomis-drol requested a review from joro75 January 31, 2022 18:50
joro75
joro75 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@joro75 joro75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Several good improvements! 👍👍

@joro75 joro75 merged commit 1711cd8 into master Jan 31, 2022
@joro75 joro75 deleted the refactor branch January 31, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joro75 joro75 joro75 approved these changes

Assignees
No one assigned
Labels
🔧 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DurgNomis-drol @joro75 @CM000n