Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'da-dk' and 'europe' as the default locale and region #127

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

joro75
Copy link
Collaborator

@joro75 joro75 commented Jan 30, 2022

As we have seen that the locale has no effect on the communication with the server, we can provide a default locale. Also 'europe' is the only valid region until now, so we can also provide that as default.

@joro75
Copy link
Collaborator Author

joro75 commented Jan 30, 2022

Also see discussion: #118

Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks!

@DurgNomis-drol DurgNomis-drol merged commit b26c6b2 into DurgNomis-drol:master Jan 30, 2022
@joro75 joro75 deleted the defaultLocale branch January 30, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants