Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better check if car is supported before creating vehicle object #101

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Better check if car is supported before creating vehicle object #101

merged 1 commit into from
Nov 6, 2021

Conversation

DurgNomis-drol
Copy link
Owner

Also adds some tests to make sure this works.

Ref: DurgNomis-drol/ha_toyota#74

@DurgNomis-drol DurgNomis-drol requested a review from joro75 November 6, 2021 09:21
joro75
joro75 approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@joro75 joro75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find a problem. OK for me.

@joro75 joro75 merged commit fbdd42c into master Nov 6, 2021
@joro75 joro75 deleted the patch branch November 6, 2021 11:28
@DurgNomis-drol
Copy link
Owner Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joro75 joro75 joro75 approved these changes

Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DurgNomis-drol @joro75 @CM000n