Correctly handle a possible divide by zero in convert_to_mpg (#78)

DurgNomis-drol · Oct 11, 2021 · 75d5447 · 75d5447
1 parent c85b3bb
commit 75d5447
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/mytoyota/utils.py b/mytoyota/utils.py
@@ -55,4 +55,6 @@ def convert_to_liter_per_100_miles(liters: float) -> float:
 def convert_to_mpg(liters_per_100_km: float) -> float:
     """Convert to miles per UK gallon (MPG)"""
     _LOGGER.debug("Converting to MPG...")
-    return round(282.5 / liters_per_100_km, 4)
+    if liters_per_100_km > 0.0:
+        return round(282.5 / liters_per_100_km, 4)
+    return 0.0
diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -102,9 +102,9 @@ def test_convert_to_liter_per_100_miles(self, liters_km, per_mile):
     @pytest.mark.parametrize(
         "liters_km,mpg",
         [
+            (0, 0),
+            (0.01, 28250.0),
             (1, 282.5),
-            # Joro75: A divide by zero is triggered!!
-            # (0, 0),
             (12, 23.5417),
         ],
     )