Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate routes for Searching and Found User #719

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

ayushmaz
Copy link
Contributor

@ayushmaz ayushmaz commented Nov 18, 2024

Fixes Issue

**My PR closes #659 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Created a new component MatchFound and transferred both the UI and business logic required after an user is matched
  • Searching component is responsible for searching, stopping a search request and navigate to /founduser once User is matched.
  • Added a new /searching route in App file

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

whisper-searching-route.mov

Copy link

vercel bot commented Nov 18, 2024

Someone is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 19, 2024 6:03am

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, this is really awesome, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit b8efb6e into Dun-sin:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Sepreate searching and foundUser into different routes
2 participants