Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a hook for closing chat #702

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

Dun-sin
Copy link
Owner

@Dun-sin Dun-sin commented Oct 12, 2024

Fixes Issue

**My PR closes #698 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Wrap start.jsx with the ChatProvider
  • make the connectWithId a promise function so we await connectivity with socket and make sure it's done before any operation
  • create the close chat button
  • Change event name for after chat has been closed from new_event_close to new_event_closed

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 12, 2024 0:05am

@Dun-sin Dun-sin temporarily deployed to feat/hook-for-closing-chat - WhisChat PR #702 October 12, 2024 12:05 — with Render Destroyed
@Dun-sin Dun-sin merged commit 7a65dac into main Oct 12, 2024
3 checks passed
@Dun-sin Dun-sin deleted the feat/hook-for-closing-chat branch October 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] create a custom hook for closing a chat
1 participant