Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles : changed the span to a button for the is bad words element #666 #696

Closed

Conversation

vikashjoshi187
Copy link

[OTHER] change the span to a button for the is bad words element

My PR closes #666

πŸ‘¨β€πŸ’» Changed the span tags to button tags

βœ… Done

Screenshot 2024-09-15 at 5 14 07β€―PM

Copy link

vercel bot commented Sep 15, 2024

Someone is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@vikashjoshi187
Copy link
Author

Hi everyone,

This is my first contribution to this project, and I am excited to be part of it. I’ve done my best to follow the guidelines, but if there are any mistakes or improvements needed, I sincerely apologize and welcome any feedback to help me learn and improve.

Thank you for reviewing my work!

Best regards,
Vikas Joshi

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 16, 2024

@vikashjoshi187 thanks for wanting to contribute, but you broke one of the most important guidelines in open source, try reading our contributing guideline instead of just the readme

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 16, 2024

Will close this, hope you continue to contribute to this project the proper way.

@Dun-sin Dun-sin closed this Sep 16, 2024
@vikashjoshi187
Copy link
Author

vikashjoshi187 commented Sep 16, 2024

Thanks @Dun-sin i will keep that in mind in my next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] change the span to a button for the is bad words element
2 participants