Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combine activeUser and User to one collection #642

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Dun-sin
Copy link
Owner

@Dun-sin Dun-sin commented Aug 12, 2024

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • delete activeUser collection/model
  • change User model to have the same fields as activeUser had
  • created a function to generate the right kind of id acceptable by mongodb
  • pass loginid when creating a user
  • change every ActiveUser ref to User
  • when deleting an ActiveUser only delete them if they don't have an email so we can check the actual amount of users we have

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Copy link

render bot commented Aug 12, 2024

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper ❌ Failed (Inspect) Aug 12, 2024 0:16am
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 12, 2024 0:16am

@Dun-sin Dun-sin merged commit 910582d into main Aug 12, 2024
3 of 4 checks passed
@Dun-sin Dun-sin deleted the refactor/use-user-model branch August 12, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant